[SERVER-55756] Allow archiving data for after-suite hooks Created: 02/Apr/21  Updated: 23/Jan/24

Status: Open
Project: Core Server
Component/s: Replication, Testing Infrastructure
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Robert Guo (Inactive) Assignee: [DO NOT ASSIGN] Backlog - DevProd Correctness
Resolution: Unresolved Votes: 1
Labels: dp-qp-stakeholder-request-2021-04, dp-qp-stakeholder-request-2021-07, tig-data-archival
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to SERVER-82532 Complete TODO listed in SERVER-55756 Needs Scheduling
Assigned Teams:
Correctness
Participants:
Linked BF Score: 0

 Description   

Updated description:

Allow data archival during teardown failures

 

Original description:

The PeriodicKillSecondaries test hook calls the run function in the after_suite callback, when all tests have finished. Most resmoke/Evergreen functionality like reporting and data archival operate on a per-test basis and may not be available at the suite level.

Consider not running the hook in after_suite.

If there's a need to keep the functionality, please reassign the ticket back to STM and we can look into allowing after_test to track if the last test has run.



 Comments   
Comment by Robert Guo (Inactive) [ 25/Oct/21 ]

Closing this issue since it looks like the linked BF has only happened once. Please feel free to reopen if there's any other indication of failures during any of the "kill" or "terminate" resmoke.py hooks that have missing data files.

Comment by Robert Guo (Inactive) [ 05/Apr/21 ]

Yeah good point. I'll change this ticket to include archival for teardown, which would've captured the PeriodicKillSecondaries issue.

Comment by Max Hirschhorn [ 02/Apr/21 ]

My recollection is that PeriodicKillSecondaries uses after_suite() because it doesn't know when the last test is being run. It is otherwise possible for the whole test suite to run and for the secondaries to not be killed once during it.

Does not having archival in this instance mean that we would similarly not have archival in other teardown failures with SERVER-55249?

Generated at Thu Feb 08 05:37:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.