[SERVER-55760] Cancelation tests for AsyncTry are racy Created: 02/Apr/21 Updated: 29/Oct/23 Resolved: 23/Jun/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.3, 5.1.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Matthew Saltz (Inactive) | Assignee: | Alex Li |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | save-for-alex, servicearch-wfbf-day | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v5.0
|
||||||||
| Sprint: | Service Arch 2021-06-14, Service Arch 2021-06-28 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 124 | ||||||||
| Description |
|
These two tests that AsyncTryUntilWithDelay loops can be canceled by a CancellationToken should be split into four tests that use barriers to specify exactly when cancelSource.cancel() is called with respect to the execution of the loop. E.g. AsyncTryUntilWithBackoffCanBeCanceled should be changed to AsyncTryUntilWithBackoffCanBeCanceledAfterLoopIsDoneExecuting and AsyncTryUntilWithBackoffCanBeCanceledWhileLoopIsExecuting. Example code for the former:
This will help tease out more possible bugs in the implementation. |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 10/Aug/21 ] |
|
Author: {'name': 'Alex Li', 'email': 'alex.li@mongodb.com', 'username': 'alexli12456'}Message: (cherry picked from commit db5c817ceaeef2aadf86832f7878c50d32cbd382) |
| Comment by Githook User [ 23/Jun/21 ] |
|
Author: {'name': 'Alex Li', 'email': 'alex.li@mongodb.com'}Message: |