[SERVER-55808] icecream and ninja affecting configure commands Created: 06/Apr/21  Updated: 29/Oct/23  Resolved: 09/Apr/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Bug Priority: Major - P3
Reporter: Daniel Moody Assignee: Daniel Moody
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Steps To Reproduce:

Generate ninja build with VERBOSE=1, and notice the config logs for fallocate are empty, it should have the commands used for the configure check printed to the logs.

 

Also using icecream, after you have fixed ninja breaking the logs, you will notice the same fallocate configure step has icerun in it.

Sprint: Dev Platform 2021-04-19
Participants:

 Description   

The configure steps should not be affected by icecream or ninja because these tools are used during the actual build and not in build preparation.

Ninja was hiding the conf logs, by making a noop function for 
PRINT_CMD_LINE_FUNC.
 
Icecream was using icerun for configure commands which use some of the builders besides compilation builders, which in those cases icecream should handle and run locally, however in some cases icecream will hang, causing confusion when this happens during a configure check. In order to reduce the number of moving parts, icecream should take no part in general configure steps.



 Comments   
Comment by Githook User [ 09/Apr/21 ]

Author:

{'name': 'Daniel Moody', 'email': 'daniel.moody@mongodb.com', 'username': 'dmoody256'}

Message: SERVER-55808 added more conftest checking to icecream and ninja tools.
Branch: master
https://github.com/mongodb/mongo/commit/59965cf5430b8132074771c0d9278a3a4b1e6730

Generated at Thu Feb 08 05:37:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.