[SERVER-55884] Complete TODO listed in SERVER-53916 Created: 07/Apr/21  Updated: 06/Dec/22  Resolved: 24/May/21

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: PM Bot Assignee: [DO NOT USE] Backlog - Sharding NYC
Resolution: Duplicate Votes: 0
Labels: autogen-todo
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates SERVER-55683 Remove waiting for minimum duration f... Closed
Related
is related to SERVER-53916 Create commitReshardCollection command Closed
Assigned Teams:
Sharding NYC
Participants:

 Description   

There is a TODO in the codebase referencing a resolved ticket which is assigned to you.

Please follow this link to see the lines of code referencing this resolved ticket:
https://github.com/mongodb/mongo/search?q=SERVER-53916&type=Code

The next steps for this ticket are to either remove the outdated TODO or follow the steps in the TODO if it is correct. If the latter, please update the summary and description of this ticket to represent the work you're actually doing.



 Comments   
Comment by Max Hirschhorn [ 09/Apr/21 ]

My intent is for waitForMinimumOperationDuration() to be removed from the resharding coordinator as part of SERVER-55683. Also related is that I'm intending for the notion of RecipientStateEnum::kSteadyState to be removed as part of SERVER-55684.

Comment by Billy Donahue [ 07/Apr/21 ]

This is in the ReshardingCoordinator::_runUntilReadyToPersistDecision function.

...
        .then([this, executor] { return _awaitAllRecipientsFinishedCloning(executor); })
        .then([this, executor] { _tellAllDonorsToRefresh(executor); })
        .then([this, executor] {
            // TODO SERVER-53916 to verify that the following runs only after the last recipient
            // shard reports to the coordinator that it has entered "steady-state".
            return waitForMinimumOperationDuration(**executor, _ctHolder->getAbortToken());
        })
        .then([this, executor] { return _awaitAllRecipientsFinishedApplying(executor); })
        .then([this, executor] { _tellAllDonorsToRefresh(executor); })
...

I don't think the todo really was in scope for SERVER-53916

Generated at Thu Feb 08 05:37:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.