[SERVER-56112] [SBE] Remove redundant oplog locking in TransactionHistoryIterator::next() path Created: 15/Apr/21  Updated: 27/Oct/23  Resolved: 23/Jun/21

Status: Closed
Project: Core Server
Component/s: Query Execution
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Mindaugas Malinauskas Assignee: Backlog - Query Execution
Resolution: Gone away Votes: 0
Labels: sbe-post-v1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-57096 [SBE] Nested (non-lock free) AutoGets... Closed
Assigned Teams:
Query Execution
Participants:

 Description   

When SBE is on, in TransactionHistoryIterator::next() oplog lock is acquired in findOneOplogEntry() and by SBE in ScanStage. Remove the redundant oplog locking.



 Comments   
Comment by David Storch [ 23/Jun/21 ]

The redundant locking described here no longer exists due to the changes made in SERVER-57096. Namely, SBE PlanExecutors now fully require the external lock policy. This means that the caller is required to hold the appropriate locks, and the SBE scan and ixscan stages no longer acquire any locks themselves. Therefore, the TransactionHistoryIterator needs to keep holding the AutoGetOplog.

Closing this ticket as "Gone Away".

Generated at Thu Feb 08 05:38:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.