[SERVER-56164] All performance projects use the master DSI branch Created: 12/Nov/20  Updated: 29/Oct/23  Resolved: 03/May/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.2.14, 4.0.25, 4.2.15, 4.4.7

Type: Improvement Priority: Major - P3
Reporter: Vlad Rachev (Inactive) Assignee: Vlad Rachev (Inactive)
Resolution: Fixed Votes: 1
Labels: tig-evgconfig
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Duplicate
Gantt Dependency
Problem/Incident
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4, v4.2, v4.0, v3.6
Sprint: TIPS 2021-05-03
Participants:
Linked BF Score: 0
Story Points: 3

 Description   

This is propping up due to auth. The auth fix involved a DSI piece and a 10gen/workloads piece. The fix in workloads broke the tests that misconfigure auth, and the fix to that in DSI is only available in the master branch. This leaves older sys-perf projects with some broken tests.

Repurposing this ticket to backport system-perf.yml and perf.yml to make all performance projects use the master DSI branch. Once this is done the legacy branch can be deleted. This should be done once PM-1822 is complete.



 Comments   
Comment by Githook User [ 10/May/21 ]

Author:

{'name': 'vrachev', 'email': 'vlad.rachev@mongodb.com', 'username': 'vrachev'}

Message: SERVER-56164 Use real compile
Branch: v4.4
https://github.com/mongodb/mongo/commit/fcc1327fcd87b5c94fcf7a8967260ef552681eb5

Comment by Githook User [ 10/May/21 ]

Author:

{'name': 'vrachev', 'email': 'vlad.rachev@mongodb.com', 'username': 'vrachev'}

Message: SERVER-56164 system_perf.yml and perf.yml use finalized DSI api
Branch: v4.4
https://github.com/mongodb/mongo/commit/57675b4b137510c382d35a2aee7eaded9ff61fe5

Comment by Githook User [ 03/May/21 ]

Author:

{'name': 'vrachev', 'email': 'vlad.rachev@mongodb.com', 'username': 'vrachev'}

Message: SERVER-56164 system_perf.yml and perf.yml use finalized DSI api
Branch: v4.2
https://github.com/mongodb/mongo/commit/f2bda62a069cc3b04d8110096b1b8cda1a4b2899

Comment by Githook User [ 03/May/21 ]

Author:

{'name': 'vrachev', 'email': 'vlad.rachev@mongodb.com', 'username': 'vrachev'}

Message: SERVER-56164 system_perf.yml and perf.yml use finalized DSI api
Branch: v4.0
https://github.com/mongodb/mongo/commit/f8427418eb94cf5ac9135084d172c655954d20b8

Comment by Githook User [ 29/Apr/21 ]

Author:

{'name': 'vrachev', 'email': 'vlad.rachev@mongodb.com', 'username': 'vrachev'}

Message: Revert "SERVER-56164 system_perf.yml and perf.yml use finalized DSI api"

This reverts commit f4579a4bdd80f7884c3352089c034f97de80b464.
Branch: v4.2
https://github.com/mongodb/mongo/commit/2002e6c2cb0e90fa47b30bfea8add8fbc3a412b5

Comment by Githook User [ 29/Apr/21 ]

Author:

{'name': 'vrachev', 'email': 'vlad.rachev@mongodb.com', 'username': 'vrachev'}

Message: revert both SERVER-56164 commits
Branch: v4.0
https://github.com/mongodb/mongo/commit/cca83042de7282134e35fc0e737374ed770e57d4

Comment by Githook User [ 28/Apr/21 ]

Author:

{'name': 'vrachev', 'email': 'vlad.rachev@mongodb.com', 'username': 'vrachev'}

Message: SERVER-56164 Fix mmap microbenchmarks variants
Branch: v4.0
https://github.com/mongodb/mongo/commit/55d0757d547dfeb6c93fe48ae32c4d6097f36a41

Comment by Githook User [ 27/Apr/21 ]

Author:

{'name': 'vrachev', 'email': 'vlad.rachev@mongodb.com', 'username': 'vrachev'}

Message: SERVER-56164 system_perf.yml and perf.yml use finalized DSI api
Branch: v4.2
https://github.com/mongodb/mongo/commit/f4579a4bdd80f7884c3352089c034f97de80b464

Comment by Githook User [ 27/Apr/21 ]

Author:

{'name': 'vrachev', 'email': 'vlad.rachev@mongodb.com', 'username': 'vrachev'}

Message: SERVER-56164 system_perf.yml and perf.yml use finalized DSI api
Branch: v4.0
https://github.com/mongodb/mongo/commit/448a47feca211f83a6357dd57066737424bce6e9

Comment by Vlad Rachev (Inactive) [ 20/Apr/21 ]

Looks like we'll EOL 3.6 sometime this month. In that case I don't think it's worth backporting to 3.6 for a week or 2 of service.

Comment by Githook User [ 20/Apr/21 ]

Author:

{'name': 'vrachev', 'email': 'vlad.rachev@mongodb.com', 'username': 'vrachev'}

Message: SERVER-56164 clean up system_perf.yml and perf.yml spacing
Branch: master
https://github.com/mongodb/mongo/commit/748009d94ee2133e9315117fc0324bd39550f7d4

Comment by Vlad Rachev (Inactive) [ 20/Apr/21 ]

david.daly ryan.timmons Who needs to be involved in determining whether we can turn off 3.6?

Comment by David Daly [ 20/Apr/21 ]

vlad.rachev if we haven't decommissioned 3.6 yet, we should backport to it. It's worth asking again though if we can turn off 3.6 now that it's EOL. 

Comment by Githook User [ 20/Apr/21 ]

Author:

{'name': 'vrachev', 'email': 'vlad.rachev@mongodb.com', 'username': 'vrachev'}

Message: SERVER-56164 system-perf.yml and perf.yml follow finalized DSI api
Branch: master
https://github.com/mongodb/mongo/commit/f93267eb27588b7e5195d500f7dad738b3db7b81

Comment by Ryan Timmons [ 20/Apr/21 ]

(the question is really if we can disable sys-perf-3.6 and performance-3.6 at this point)

Comment by Vlad Rachev (Inactive) [ 20/Apr/21 ]

david.daly Do we need to backport to 3.6 or only to 4.0? 

Comment by Ryan Timmons [ 20/Apr/21 ]

I'm not sure we need to backport to 3.6 - may want to confirm with product perf.

Comment by Brooke Miller [ 19/Apr/21 ]

ryan.timmons is back from vacation yet still thinks this is a good ticket for vlad.rachev to complete. Ryan will sync up with Vlad today to discuss remaining to-dos to complete this work. 

Comment by Ryan Timmons [ 25/Jan/21 ]

This can be done as a part of PM-2055.

Comment by Brooke Miller [ 25/Jan/21 ]

ryan.timmons should we still wait to do this once PM-2055 is complete, or could we do this earlier?

Comment by Brooke Miller [ 24/Nov/20 ]

We decided to backport the yaml changes, instead of creating a legacy branch. vlad.rachev will create a ticket or update this ticket accordingly.

Comment by Ryan Timmons [ 18/Nov/20 ]

I'd really like to not have the legacy branches. It's not a huge task to backport the evergreen yaml changes and saves us from having to have an awkward transition periods. This was slated for SERVER-50224 which I think we could revive as a BF day item once the rest of PM-1822 is done.

Comment by David Daly [ 17/Nov/20 ]

SGTM. We shouldn't leave the old branches broken.

Comment by Brooke Miller [ 17/Nov/20 ]

robert.guo mentioned that it might be hard to ask the maintainers of the workloads repo to commit their changes to two branches. However, there aren't many people contributing to that repo and all the commits are for new features, so we may want to go with the first option suggested.

To do so, we should:

  • Create the legacy branch and update the PR template to include that there's a legacy branch that should be contributed to, if needed.
  • Update legacy_sys_perf.yml, perf.yml to reference the legacy branch
  • Revert the auth change in workloads in doing this.

ryan.timmons when you're back, could you provide your input here? Also, david.daly, does this sound good to you?

Generated at Thu Feb 08 05:38:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.