[SERVER-56275] Check all ways that an opCtx will be interrupted for step up and step down Created: 22/Apr/21 Updated: 29/Oct/23 Resolved: 07/Jul/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Samyukta Lanka | Assignee: | Xuerui Fa |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Repl 2021-06-28, Repl 2021-07-12 | ||||||||
| Participants: | |||||||||
| Description |
|
We currently sometimes check if the global lock was taken in a mode conflicting with writes to ensure that an operation will be killed during step up or step down (like here). However, that's no longer the only situation that we kill an opCtx anymore, so we should update those checks to call opCtx->shouldAlwaysInterruptAtStepDownOrUp() as well. |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 07/Jul/21 ] |
|
Author: {'name': 'XueruiFa', 'email': 'xuerui.fa@mongodb.com', 'username': 'XueruiFa'}Message: |
| Comment by Billy Donahue [ 27/Apr/21 ] |
|
Can we get a clarification about what ServiceArch should do about this? |
| Comment by Samyukta Lanka [ 22/Apr/21 ] |
|
We also might as well update range_deletion_util.cpp to call setAlwaysInterruptAtStepDownOrUp instead of taking and immediately releasing the global lock. |