[SERVER-56314] Internal system threads with kIgnoreConflictsAllWrites set and running wiredTigerPrepareConflictRetry code should not be required to be killable for stepdown Created: 23/Apr/21 Updated: 30/Apr/21 Resolved: 30/Apr/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Dianna Hohensee (Inactive) |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v4.4
|
||||||||
| Sprint: | Execution Team 2021-05-03 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 115 | ||||||||
| Description |
|
We set index builds to ignore prepare conflicts using the kIgnoreConflictsAllowWrites setting, which appears to only be used to set a flag on a WT request, but then we also enforce that internal threads can be killed for step-down in order to avoid hangs with said threads hitting prepare conflicts, without any apparent exception for threads that have kIgnoreConflictsAllowWrites set. I believe there should be an exception to the client->canKillSystemOperationInStepdown() invariant where internal threads with kIgnoreConflictsAllowWrites set should not be required to be killable. |
| Comments |
| Comment by Dianna Hohensee (Inactive) [ 30/Apr/21 ] |
|
Louis noticed in the CR that the code doesn't behave how we originally thought it. See below. Closing this and reopening the BF for investigation. > > The prepareConflictRetry helper takes some WT API call, "f", and calls it on |