[SERVER-56490] Replace expensive ddl_utils calls to catalog client with batched requests Created: 29/Apr/21  Updated: 29/Oct/23  Resolved: 04/Jun/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: 5.0.0-rc0
Fix Version/s: 5.0.0-rc1, 5.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Pierlauro Sciarelli Assignee: Pierlauro Sciarelli
Resolution: Fixed Votes: 0
Labels: PM-1965-Cleanup, post-rc0
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v5.0
Sprint: Sharding EMEA 2021-05-31, Sharding EMEA 2021-06-14
Participants:

 Description   

Since cluster writes can't be unit tested, some DDL utilities had been written using catalog client calls that can be very inefficient. Considering that also batched requests are unit-testable (when using the ConfigServerFixture - as in ddl util tests), some performance improvements can be applied.

Performance problems:

  • The updateTags function uses the catalog client to update tags in an extremely inefficient way.
  • The deletion of chunks / tags can hit the catalog client timeout in case of a lot of documents to delete.

Action points:

  • Replace updateTags logic with a simple batch update.
  • Replace the above mentioned delete calls with batched deletes.


 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 04/Jun/21 ]

Author:

{'name': 'Pierlauro Sciarelli', 'email': 'pierlauro.sciarelli@mongodb.com', 'username': 'pierlauro'}

Message: SERVER-56490 Replace expensive ddl_utils calls to catalog client with batched requests (BACKPORT-9353)
Branch: v5.0
https://github.com/mongodb/mongo/commit/46a7ce2631d5a5effde4ebee2ddfaae3a5dfa87a

Comment by Githook User [ 04/Jun/21 ]

Author:

{'name': 'Pierlauro Sciarelli', 'email': 'pierlauro.sciarelli@mongodb.com', 'username': 'pierlauro'}

Message: SERVER-56490 Replace expensive ddl_utils calls to catalog client with batched requests (minor change)
Branch: master
https://github.com/mongodb/mongo/commit/03d924729401107516e5a50dacb8f8c76943175e

Comment by Githook User [ 04/Jun/21 ]

Author:

{'name': 'Pierlauro Sciarelli', 'email': 'pierlauro.sciarelli@mongodb.com', 'username': 'pierlauro'}

Message: SERVER-56490 Replace expensive ddl_utils calls to catalog client with batched requests
Branch: master
https://github.com/mongodb/mongo/commit/bb682f4248bac609f013bbf44e0798ae9e722b9c

Generated at Thu Feb 08 05:39:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.