[SERVER-56585] deprecate MONGO_COMPILER_VARIABLE_UNUSED in favor of C++ 17 attributes maybe_unused Created: 03/May/21 Updated: 29/Oct/23 Resolved: 05/May/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.0-rc0 |
| Type: | Improvement | Priority: | Trivial - P5 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | servicearch-wfbf-day | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Execution Team 2021-05-17 | ||||||||
| Participants: | |||||||||
| Story Points: | 1 | ||||||||
| Description |
|
We have been using the C++ 17 attribute maybe_unused in the server code base for a while now (earliest detected usage was in https://github.com/mongodb/mongo/search?q=maybe_unused&type=Code https://github.com/mongodb/mongo/search?q=MONGO_COMPILER_VARIABLE_UNUSED&type=Code |
| Comments |
| Comment by Githook User [ 05/May/21 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: This macro is no longer necessary now that we have [[maybe_unused]]. |
| Comment by Githook User [ 05/May/21 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 04/May/21 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Benety Goh [ 04/May/21 ] |
|
This issue was raised while reviewing |