[SERVER-56607] Coverity analysis defect 119982: 'Constant' variable guards dead code Created: 04/May/21  Updated: 29/Oct/23  Resolved: 05/May/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Coverity Collector User Assignee: Huayu Ouyang
Resolution: Fixed Votes: 0
Labels: coverity
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-56608 Coverity analysis defect 119982: 'Con... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

'Constant' variable guards dead code

A variable being assigned only once may be intentionally guarding disabled code, or it may represent incomplete logic where a missing assignment would make the variable not be constant. Variable assigned once to a constant guards dead code.
/src/mongo/db/write_concern.cpp:97: DEADCODE 119982 Assigning: "getLastErrorDefaultsWasApplied" = "false".
/src/mongo/db/write_concern.cpp:142: DEADCODE 119982 At condition "getLastErrorDefaultsWasApplied", the value of "getLastErrorDefaultsWasApplied" must be equal to 0.
/src/mongo/db/write_concern.cpp:142: DEADCODE 119982 The condition "getLastErrorDefaultsWasApplied" cannot be true.
/src/mongo/db/write_concern.cpp:143: DEADCODE 119982 Execution cannot reach the expression "provenance->setSource(boost::optional<mongo::ReadWriteConcernProvenanceSourceEnum>(mongo::ReadWriteConcernProvenanceSourceEnum(mongo::ReadWriteConcernProvenanceSourceEnum::getLastErrorDefaults)))" inside this statement: "provenance->setSource(boost...".



 Comments   
Comment by Githook User [ 05/May/21 ]

Author:

{'name': 'Huayu Ouyang', 'email': 'huayu.ouyang@mongodb.com', 'username': 'huayu-ouyang'}

Message: SERVER-56607 Remove unused getLastErrorDefaultsWasApplied variable
Branch: master
https://github.com/mongodb/mongo/commit/8c5f7e07671ffff208be4ac1aae867370a0b4e98

Generated at Thu Feb 08 05:39:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.