[SERVER-56630] Unittest OpObserverImpl::onDelete/onUpdate paths for retryable findAndModify Created: 04/May/21 Updated: 29/Oct/23 Resolved: 22/Jun/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.25, 4.2.15, 4.4.7, 5.0.0-rc1, 5.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Daniel Gottlieb (Inactive) | Assignee: | Daniel Gottlieb (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Requested: |
v5.0, v4.4, v4.2, v4.0
|
||||
| Sprint: | Repl 2021-06-14, Repl 2021-06-28 | ||||
| Participants: | |||||
| Description |
|
The contracts for what different inputs to OpObserverImpl generate what oplog entries could use some hardening. The following table can be used as a starting point for what a unittest can cover (note [oplogEntry.]`NeedsRetryImage` is the only output being asserted):
Other inputs to consider:
|
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 22/Jun/21 ] |
|
Author: {'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}Message: |
| Comment by Githook User [ 22/Jun/21 ] |
|
Author: {'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}Message: |
| Comment by Githook User [ 22/Jun/21 ] |
|
Author: {'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}Message: |
| Comment by Githook User [ 03/Jun/21 ] |
|
Author: {'name': 'Jason Chan', 'email': 'jason.chan@mongodb.com', 'username': 'jasonjhchan'}Message: (cherry picked from commit d78928f90492739ce5401d112b0fe89e278d3954) |
| Comment by Githook User [ 03/Jun/21 ] |
|
Author: {'name': 'Jason Chan', 'email': 'jason.chan@mongodb.com', 'username': 'jasonjhchan'}Message: (cherry picked from commit d78928f90492739ce5401d112b0fe89e278d3954) |
| Comment by Githook User [ 01/Jun/21 ] |
|
Author: {'name': 'Jason Chan', 'email': 'jason.chan@mongodb.com', 'username': 'jasonjhchan'}Message: (cherry picked from commit 68c6fbfe69283f70ff321cfaa7cb2a533747ac36) |
| Comment by Githook User [ 26/May/21 ] |
|
Author: {'name': 'Jason Chan', 'email': 'jason.chan@mongodb.com', 'username': 'jasonjhchan'}Message: (cherry picked from commit d78928f90492739ce5401d112b0fe89e278d3954) |
| Comment by Githook User [ 18/May/21 ] |
|
Author: {'name': 'Jason Chan', 'email': 'jason.chan@10gen.com', 'username': 'jasonjhchan'}Message: |
| Comment by Daniel Gottlieb (Inactive) [ 14/May/21 ] |
|
We should also add unittests for chunk migration with these new retryable write oplog entries. Or ticket that out separately if convenient. |