[SERVER-56717] Use faster value comparison for Timeseries MinMax store Created: 06/May/21  Updated: 29/Oct/23  Resolved: 25/Jun/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Henrik Edin Assignee: Alison Lu (Inactive)
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
causes SERVER-61106 Time-series bucket min/max summaries ... Closed
Related
related to SERVER-58094 Replace BSONElement::woCompare calls ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2021-06-28, Execution Team 2021-07-12
Participants:

 Description   

Right now the comparison is using three way comparison with the spaceship operator. It is also handling comparisons where the types are different requiring more branches in the comparison code.

We should utilize the fact that we've already compared the types and just need a simple less or more compare.



 Comments   
Comment by Githook User [ 25/Jun/21 ]

Author:

{'name': 'Alison Lu', 'email': 'alison.lu@mongodb.com'}

Message: SERVER-56717 Update compare() comment with CodeWScope case
Branch: master
https://github.com/mongodb/mongo/commit/aab2480c9fffea77c007a24f13ae7ba2661d376a

Comment by Githook User [ 25/Jun/21 ]

Author:

{'name': 'Alison Lu', 'email': 'alison.lu@mongodb.com'}

Message: SERVER-56717 Add ComparisonRulesSet as a parameter
Branch: master
https://github.com/mongodb/mongo/commit/b85dd8c9e4ad377a9bc985cfcc82016a4fa16b8e

Comment by Githook User [ 25/Jun/21 ]

Author:

{'name': 'Alison Lu', 'email': 'alison.lu@mongodb.com'}

Message: SERVER-56717 Update naming and comment, simplify comparisons
Branch: master
https://github.com/mongodb/mongo/commit/faa111304a5301eb321b016029766104de6d9272

Generated at Thu Feb 08 05:40:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.