[SERVER-56750] Check for todo comments as part of running upload.py Created: 07/May/21  Updated: 29/Oct/23  Resolved: 12/May/21

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 5.0.0-rc0

Type: New Feature Priority: Major - P3
Reporter: David Bradford (Inactive) Assignee: David Bradford (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-56751 Check for todo comments as part of ru... Closed
Backwards Compatibility: Fully Compatible
Sprint: DAG 2021-05-17
Participants:
Story Points: 2

 Description   

We recently added todo comment checking as part of the server commit queue. This is
useful, but fails a commit-queue entry if something is wrong. It would be nice to have
some early checks as well to warn engineers that there is an issue before submitting to
the commit-queue.

One possible solution is to add the check to the upload.py script. This script already
has options to do things like linting, so the todo check should fit in with those.


As a database contributor,
I want to about unresolved todo in my code before commit-queue time,
So that I can fix them before I submit my code to the commit-queue.


AC:

  • Check for Todo comments happe as part of running upload.py


 Comments   
Comment by Githook User [ 11/May/21 ]

Author:

{'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}

Message: SERVER-56750: Add support for checking TODO comments in upload.py (#256)
Branch: master
https://github.com/10gen/kernel-tools/commit/8cead9c541ed4b314da8d372b7091b9c726f817d

Generated at Thu Feb 08 05:40:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.