[SERVER-56751] Check for todo comments as part of running patch build Created: 07/May/21  Updated: 29/Oct/23  Resolved: 12/May/21

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.9.0-rc1, 4.4.7, 5.0.0-rc0

Type: New Feature Priority: Major - P3
Reporter: David Bradford (Inactive) Assignee: David Bradford (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
related to SERVER-56750 Check for todo comments as part of ru... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.9, v4.4
Sprint: DAG 2021-05-17
Participants:
Story Points: 2

 Description   

We recently added todo comment checking as part of the server commit queue. This is
useful, but fails a commit-queue entry if something is wrong. It would be nice to have
some early checks as well to warn engineers that there is an issue before submitting to
the commit-queue.

One possible solution is to add a todo check task to required patch builds. This would
likely rely on the ticket being included as part of tha patch description, but if we
could find a ticket, check that, otherwise just no-op.


As a database contributor,
I want to about unresolved todo in my code before commit-queue time,
So that I can fix them before I submit my code to the commit-queue.


AC:

  • A task exists that is part of a required builder that will check for TODO tickets if
    a ticket was provided.


 Comments   
Comment by Githook User [ 12/May/21 ]

Author:

{'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}

Message: SERVER-56751: Add patch build task for todo comment checks

(cherry picked from commit d2da02cf6654b60948408cdcaaf9c520e8d1bc0e)
(cherry picked from commit 42004e2c2bf59e586a8086d7c84724bc77085d68)
Branch: v4.4
https://github.com/mongodb/mongo/commit/2b131880f5e71c733cc628a61bf34cb2f5a813ce

Comment by Githook User [ 12/May/21 ]

Author:

{'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}

Message: SERVER-56751: Add patch build task for todo comment checks

(cherry picked from commit d2da02cf6654b60948408cdcaaf9c520e8d1bc0e)
Branch: v4.9
https://github.com/mongodb/mongo/commit/42004e2c2bf59e586a8086d7c84724bc77085d68

Comment by Githook User [ 12/May/21 ]

Author:

{'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}

Message: SERVER-56751: Add patch build task for todo comment checks
Branch: master
https://github.com/mongodb/mongo/commit/d2da02cf6654b60948408cdcaaf9c520e8d1bc0e

Generated at Thu Feb 08 05:40:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.