[SERVER-56812] Certain Evergreen tasks are marked as depending on jscore but do not respect this dependency Created: 07/May/21 Updated: 06/Oct/21 Resolved: 04/Jun/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 5.1.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Maria van Keulen | Assignee: | Tausif Rahman (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | DAG 2021-05-31, DAG 2021-06-14 |
| Participants: | |
| Story Points: | 1 |
| Description |
|
There look to be ~17 generator tasks, e.g., this one that are marked as depending on jsCore. However, this dependency is not respected, either by the generator task or by the generated tasks, e.g., this generator and this generated task. The former has no depends_on section in the UI, and the latter depends on archive_dist_test_debug instead. The syntax used for this depends_on will not be respected by Evergreen directly; it's possible the intent was for this depends_on to be passed to the evergreen_generate_resmoke_tasks.py script instead, but isn't getting parsed. If the intent is to make the generator depend on jsCore, fixing the depends_on will likely increase patch makespans, so it'd be preferable to remove this depends_on entirely and rely on EVG-14537 instead. Either way, it'd be great to address the erroneous depends_on to avoid further copy-pasting. |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 04/Jun/21 ] |
|
Author: {'name': 'trahman1318', 'email': 'tausif.rahman@mongodb.com', 'username': 'trahman1318'}Message: |
| Comment by Maria van Keulen [ 10/May/21 ] |
|
Ah I see, thank you for the detailed explanation. Removing the `depends_on` sounds good to me. |
| Comment by David Bradford (Inactive) [ 10/May/21 ] |
|
Generating tasks and dependencies gets really complicated really fast. In order for a generated task to properly `depend_on` another generated task, the first task needs to have completed generating its child tasks. Because the 2nd tasks child tasks will need to depend on all the tasks generated by the first task. In order to accomplish this, we need the generating task to depend on the generating task of the dependency (this is done via normal evergreen depends_on syntax) and we specify that generated tasks should depend on tasks generated by the dependency (this is what the `depends_on` var in the `generate resmoke tasks` call is for). In |
| Comment by Maria van Keulen [ 07/May/21 ] |
|
CC david.bradford assigning this to DAG; not sure if evergreen_generate_resmoke_tasks.py is specifically intended to rely on depends_on being a variable or not. |