[SERVER-56841] tassert() should print a backtrace to the logs on failure Created: 11/May/21 Updated: 29/Oct/23 Resolved: 13/May/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | David Storch | Assignee: | Jennifer Peshansky (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Sprint: | Query Execution 2021-05-17 | ||||
| Participants: | |||||
| Description |
|
Like invariant(), the new tassert() assertion type is indicative of a programming error when it fails. Also like invariant(), tassert() should log a backtrace. That way, if customers encounter a tassert() failure, or if tassert() fails in our testing environment, the backtrace will give us useful information for starting to diagnose the bug. |
| Comments |
| Comment by David Storch [ 13/May/21 ] |
|
Changing resolution to "Fixed" rather than "Done". |
| Comment by Githook User [ 12/May/21 ] |
|
Author: {'name': 'Jennifer Peshansky', 'email': 'jennifer.peshansky@mongodb.com', 'username': 'jenniferpeshansky'}Message: |
| Comment by David Storch [ 11/May/21 ] |
|
If this doesn't make it into the 5.0 branch, then we should backport it. I believe that this is very important for our ability to diagnose tassert() failures should they happen in customer environments. It might also help customers notice that something is wrong; having a big backtrace in the logs plus a non-zero process exit code is more obvious than the non-zero process exit code alone. |