[SERVER-56898] investigate library exclusion interface for PCH tool Created: 12/May/21  Updated: 06/Dec/22  Resolved: 28/Jun/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Daniel Moody Assignee: [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Server Development Platform
Operating System: ALL
Participants:

 Description   

While working on SERVER-55839 it was found that certain libraries did not play nice with the following header set inside the mongo/db directory:

#include <mongo/db/namespace_string.h>
#include <mongo/db/commands.h>
#include <mongo/db/auth/authorization_session.h>
#include <mongo/db/db_raii.h>

The libraries which had issues were src/mongo/db/query/datetime/date_time_support and src/mongo/db/repl/split_horizon.

For the investigation being performed in the mentioned ticket, these library were all together excluded from PCH to not spend to much time on the issue and still demonstrate measurable gains.

 

Instead of excluding the library all together at the library declaration, it would be more preferable to have it exclude the particular library for the particular PCH at the PCH declaration for neatness and making those libraries be selective for other pch's.

 

This would also allow issues found from certain libraries to not prevent potential performance gains, while other teams investigate and potentially fix such issues.


Generated at Thu Feb 08 05:40:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.