[SERVER-57016] Consider changing MozJSScriptEngine to not log "kill" events for unrecognized OperationContexts Created: 18/May/21  Updated: 06/Dec/22  Resolved: 18/May/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Question Priority: Major - P3
Reporter: Drew Paroski Assignee: Backlog - Query Execution
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Documented
Related
related to SERVER-56737 Provide a separate path for delisting... Backlog
Assigned Teams:
Query Execution
Participants:

 Description   

At present, MozJSScriptEngine prints out a log message for every ServiceContext "kill" event, even when MozJSScriptEngine doesn't recognize the OperationContext of the request being killed (see MozJSScriptEngine::interrupt()).

Given that MozJSScriptEngine registers as a listener when mongod starts up and it never unregisters, there is arguably little to no value in having MozJSScriptEngine print out log messages for "kill" events where it doesn't recognize the OperationContext.

If we think there is some value in unconditionally logging every "kill" event, then this logging should happen in ServiceContext::killOperation() or in OperationContext::markKilled().

The goal of this task is to decide between the following options:

  1. Leave things as-is.
  2. Change MozJSScriptEngine to only log "kill" events when it recognizes the OperationContext.
  3. Change MozJSScriptEngine to only log "kill" events when it recognizes the OperationContext, and update ServiceContext::killOperation() or OperationContext::markKilled() to log every "kill" event unconditionally.

See HELP-24308 for context on how this issue came up.



 Comments   
Comment by Ana Meza [ 18/May/21 ]

We think that the fix outlined in SERVER-56737 is the correct way to address this issue, so closing this as Won't Fix in favor of that work.

Comment by Kyle Suarez [ 18/May/21 ]

Flagging this for scheduling so we can discuss as a team at the triage meeting.

Generated at Thu Feb 08 05:40:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.