[SERVER-57038] Fix stack-use-after-scope of TransactionParticipant in write_ops_exec::performAtomicTimeseriesWrites Created: 18/May/21 Updated: 29/Oct/23 Resolved: 19/May/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.0-rc0, 5.1.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Gregory Noma | Assignee: | Gregory Noma |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v5.0
|
||||||||
| Sprint: | Execution Team 2021-05-31 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 168 | ||||||||
| Description |
|
We currently use a reference to a TransactionParticipant that is on the stack inside of a storage transaction rollback handler. However, due to C++ destruction ordering, when we leave the frame this variable goes out of scope before the WriteUnitOfWork whose destructor causes the handler to run. |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 20/May/21 ] |
|
Author: {'name': 'Gregory Noma', 'email': 'gregory.noma@gmail.com', 'username': 'gregorynoma'}Message: (cherry picked from commit fdb2110862484c887faac3e03d53927fdc0ad216) |
| Comment by Githook User [ 19/May/21 ] |
|
Author: {'name': 'Gregory Noma', 'email': 'gregory.noma@gmail.com', 'username': 'gregorynoma'}Message: |