[SERVER-57147] Remove outdated TODO comment referring to WT-4459 Created: 24/May/21  Updated: 29/Oct/23  Resolved: 29/Jun/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0.0-rc3

Type: Task Priority: Major - P3
Reporter: PM Bot Assignee: Monica Ng
Resolution: Fixed Votes: 0
Labels: autogen-todo
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to WT-4459 Some recovery errors lead to memory leak Closed
Backwards Compatibility: Minor Change
Sprint: Storage - Ra 2021-06-28, Storage - Ra 2021-07-12
Participants:
Story Points: 1

 Description   

There is a TODO in the codebase referencing a resolved ticket which is assigned to you.

Please follow this link to see the lines of code referencing this resolved ticket:
https://github.com/mongodb/mongo/search?q=WT-4459&type=Code

The next steps for this ticket are to either remove the outdated TODO or follow the steps in the TODO if it is correct. If the latter, please update the summary and description of this ticket to represent the work you're actually doing.



 Comments   
Comment by Githook User [ 29/Jun/21 ]

Author:

{'name': 'Monica Ng', 'email': 'monica.ng@mongodb.com', 'username': 'mm-ng'}

Message: SERVER-57147 Remove outdated TODO comment referring to WT-4459
Branch: master
https://github.com/mongodb/mongo/commit/5f5ac8d637439bda2dd42a93b0f2d6cf755b5a27

Comment by Monica Ng [ 24/Jun/21 ]

Thanks louis.williams. I have added you as a reviewer on the CR, could you please review this?

Comment by Louis Williams [ 22/Jun/21 ]

monica.ng, thanks! I think if this test fails ASAN in the future, we'll probably just stop running the test permanently. The coverage is not entirely necessary, and I would prefer to just prevent future failures by keeping the test disabled than having coverage for something that doesn't represent a world use case.

Comment by Monica Ng [ 17/Jun/21 ]

louis.williams I actually did happen to run a patch yesterday - it doesn't seem like we are running into any issues but let me know how you'd like to proceed with this.

Patch Link: https://spruce.mongodb.com/version/60ca98457742ae161d8ac233/tasks

 

Comment by Louis Williams [ 17/Jun/21 ]

monica.ng, I was thinking you could remove the conditional and run a patch build, specifically the "! {A,UB}SAN Enterprise Ubuntu 18.04 DEBUG" variant. 

After some thought, however, I don't think this test coverage is very valuable. You can just remove the comment as it is in your CR.

Comment by Monica Ng [ 17/Jun/21 ]

louis.williams How should we be checking if the problem still exists?

Comment by Louis Williams [ 16/Jun/21 ]

sue.loverso, if we remove the conditional and the problem still exists, then I think it's fine to only remove the TODO comment and continue skipping those test cases.

Comment by Susan LoVerso [ 16/Jun/21 ]

While the PR removes the TODO it does not change the test such that it will ever again run with ASAN. I assume the change that added the TODO also added the conditional below it.

louis.williams should only the comment be removed or the conditional too and see if the problem still exists? Are we gaining much reinstating that one specific test in ASAN? WT-4459 was not fixed but closed as Gone Away since it basically aged out and was almost 3 years old.

Comment by Monica Ng [ 16/Jun/21 ]

I have raised a PR in the SERVER codebase to just remove the comment. sue can you please confirm if this was the intended change as WT-4459 will not be completed anymore?

PR: https://mongodbcr.appspot.com/791300038

Comment by Deepti Hasija [ 10/Jun/21 ]

Remove this TODO as wont be doing WT-4459.

Generated at Thu Feb 08 05:41:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.