[SERVER-57185] _finalize function should not be declared noexcept on create sharded collection path Created: 25/May/21  Updated: 29/Oct/23  Resolved: 25/May/21

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 5.0.0-rc1, 5.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Marcos José Grillo Ramirez Assignee: Marcos José Grillo Ramirez
Resolution: Fixed Votes: 0
Labels: PM-1965-Milestone-1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File bf_repro.js     Text File diff.patch    
Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v5.0
Steps To Reproduce:

1. Apply the attached patch
2. Run the attached test

Sprint: Sharding EMEA 2021-05-31
Participants:
Linked BF Score: 151

 Description   

The _finalize function is declared as noexcept, however it might throw when trying to get a shard from the shard registry, this might cause the server to crash.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 25/May/21 ]

Author:

{'name': 'Marcos José Grillo Ramirez', 'email': 'marcos.grillo@mongodb.com', 'username': 'm4nti5'}

Message: SERVER-57185 Remove noexcept to _finalize function on create sharded collection path

(cherry picked from commit 04809727c63a1f9222322ab02cd141027d5337ec)
Branch: v5.0
https://github.com/mongodb/mongo/commit/8ee6225246eaf877a00071dbc9c3cf68becd19f7

Comment by Githook User [ 25/May/21 ]

Author:

{'name': 'Marcos José Grillo Ramirez', 'email': 'marcos.grillo@mongodb.com', 'username': 'm4nti5'}

Message: SERVER-57185 Remove noexcept to _finalize function on create sharded collection path
Branch: master
https://github.com/mongodb/mongo/commit/04809727c63a1f9222322ab02cd141027d5337ec

Generated at Thu Feb 08 05:41:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.