[SERVER-57212] Rename or alias repl set config settings "getLastErrorDefaults" and "getLastErrorModes" Created: 26/May/21 Updated: 06/Dec/22 Resolved: 04/Jun/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | David Storch | Assignee: | Backlog - Replication Team |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Assigned Teams: |
Replication
|
||||
| Participants: | |||||
| Description |
|
If I understand correctly, settings.getLastErrorDefaults and settings.getLastErrorModes don't really have anything to do with getLastError, but rather are writeConcern-related configuration options. This means they are now misnamed, and should probably be called something like "writeConcernDefaults" and "writeConcernModes". We should rename them or provide aliases. Note that the getLastError command was deprecated in version 5.0, and the Query Execution team is planning to remove it soon. Therefore, these misnamed options will become even more obviously misnamed, since getLastError will cease to exist in the rest of the code base. |
| Comments |
| Comment by Steven Vannelli [ 04/Jun/21 ] |
|
Hi david.storch the team decided in our Product sync that given the amount of effort to rename these fields and the current level of usage., we are not going to do this at this time. Note that we have already deprecated "getLastErrorDefaults" |
| Comment by David Storch [ 26/May/21 ] |
|
irina.yatsenko pointed out that something similar holds for serverStatus().metrics.getLastError. If I understand correctly, these serverStatus metrics give general information about writeConcern timeouts, and therefore are also misnamed in a world without the getLastError command. This seems like something that could also be fixed within the scope of this ticket. |