[SERVER-57366] venv_setup.sh should exit on pip failures Created: 02/Jun/21  Updated: 29/Oct/23  Resolved: 03/Jun/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0.0-rc1, 5.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Richard Samuels (Inactive) Assignee: Richard Samuels (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v5.0
Sprint: STM 2021-06-14
Participants:
Linked BF Score: 0
Story Points: 0

 Description   

Failures in venv setup or pip install will not fail in venv_setup.sh, and will instead lead to the deceptive error message "Failed to import a dependency. This is almost certainly because the task did not initialize the venv immediately after cloning the repository."

errexit is likely overridden somewhere in the chain of shell scripts, so we're just going to settle for || exit.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 03/Jun/21 ]

Author:

{'name': 'Richard Samuels', 'email': 'richard.l.samuels@gmail.com', 'username': 'richardsamuels'}

Message: SERVER-57366 venv_setup.sh should exit on pip errors

(cherry picked from commit 6dafe80d19b75b1ea961bc7d3bfdac01b767397a)
Branch: v5.0
https://github.com/mongodb/mongo/commit/3f38f912fd8810ba6d33a8e4f3082c206cee07dc

Comment by Githook User [ 02/Jun/21 ]

Author:

{'name': 'Richard Samuels', 'email': 'richard.l.samuels@gmail.com', 'username': 'richardsamuels'}

Message: SERVER-57366 venv_setup.sh should exit on pip errors
Branch: master
https://github.com/mongodb/mongo/commit/6dafe80d19b75b1ea961bc7d3bfdac01b767397a

Generated at Thu Feb 08 05:41:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.