[SERVER-57366] venv_setup.sh should exit on pip failures Created: 02/Jun/21 Updated: 29/Oct/23 Resolved: 03/Jun/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.0-rc1, 5.1.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Richard Samuels (Inactive) | Assignee: | Richard Samuels (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v5.0
|
||||||||
| Sprint: | STM 2021-06-14 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 0 | ||||||||
| Story Points: | 0 | ||||||||
| Description |
|
Failures in venv setup or pip install will not fail in venv_setup.sh, and will instead lead to the deceptive error message "Failed to import a dependency. This is almost certainly because the task did not initialize the venv immediately after cloning the repository." errexit is likely overridden somewhere in the chain of shell scripts, so we're just going to settle for || exit. |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 03/Jun/21 ] |
|
Author: {'name': 'Richard Samuels', 'email': 'richard.l.samuels@gmail.com', 'username': 'richardsamuels'}Message: (cherry picked from commit 6dafe80d19b75b1ea961bc7d3bfdac01b767397a) |
| Comment by Githook User [ 02/Jun/21 ] |
|
Author: {'name': 'Richard Samuels', 'email': 'richard.l.samuels@gmail.com', 'username': 'richardsamuels'}Message: |