[SERVER-57389] Delete shell and dbclient's getLastError-related helpers Created: 03/Jun/21  Updated: 29/Oct/23  Resolved: 06/Jul/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Task Priority: Major - P3
Reporter: David Storch Assignee: Irina Yatsenko (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Documented
Problem/Incident
Backwards Compatibility: Minor Change
Sprint: Query Execution 2021-07-12
Participants:
Linked BF Score: 0

 Description   

These are helpers offered by the shell to make it easier to run an explicit getLastError command against the server. However, we are removing support for the getLastError command. Therefore, we should also delete the corresponding shell helpers.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 03/Jul/21 ]

Author:

{'name': 'Irina Yatsenko', 'email': 'irina.yatsenko@mongodb.com', 'username': 'IrinaYatsenko'}

Message: SERVER-57389 Remove GLE helpers from the shell and dbclient
Branch: master
https://github.com/mongodb/mongo/commit/fde0540020340768e8a459633f57e3e23cabea3d

Comment by Irina Yatsenko (Inactive) [ 02/Jul/21 ]

On a closer inspection of throwGLE & safe options, they aren't tied to the legacy commands and though they are likely unused, cleaning them up would fall outside of PM-912 (and the ROI is low) so this ticket will only deal with dbclient and shell GLE helpers.

Comment by Irina Yatsenko (Inactive) [ 02/Jul/21 ]

dbclient has to keep getLastError for the integration testing (but we can limit the surface to the bare minimum)

yoonsoo.kim, question about bench.cpp: where can I find which options benchRun is run with? For example, I'm not seeing any mentions of throwGLE across the mongodb org other than those in bench.cpp/h. Is it safe to assume based on this search that the option is never set? (it's 'false' by default)

Comment by Yoon Soo Kim [ 11/Jun/21 ]

shell's getLastError()/getLastErrorObj()/assert.gleOK()/and etc.

dbclient's getLastError()/getLastErrorDetailed()/getLastErrorString()/and etc.

Generated at Thu Feb 08 05:41:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.