[SERVER-57403] Serialization error in let variables in a sharded cluster Created: 03/Jun/21 Updated: 29/Oct/23 Resolved: 14/Jun/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.0-rc2, 5.1.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Charlie Swanson | Assignee: | Katherine Wu (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||
| Backport Requested: |
v5.0
|
||||||||||||||||||||||||
| Sprint: | Query Optimization 2021-06-28 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
The following command should work, but doesn't on a mongos:
If you look at the profiler in the shards, it looks like we just need to preserve a $const or $literal in the serialization. That is dropped and we just end up with y: "$bar":
|
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] | |||||||||||||||||||||||||||
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! | |||||||||||||||||||||||||||
| Comment by Githook User [ 16/Jun/21 ] | |||||||||||||||||||||||||||
|
Author: {'name': 'Katherine Wu', 'email': 'katherine.wu@mongodb.com', 'username': 'kaywux'}Message: | |||||||||||||||||||||||||||
| Comment by Katherine Wu (Inactive) [ 15/Jun/21 ] | |||||||||||||||||||||||||||
|
jmikola This has now been backported to 5.0 and should be in the rc2 preview release. I've checked the "Downstream Team Attention" for drivers on this ticket since the backport ticket didn't have that metadata field available. Let me know if there are any other issues regarding this! | |||||||||||||||||||||||||||
| Comment by Githook User [ 15/Jun/21 ] | |||||||||||||||||||||||||||
|
Author: {'name': 'Katherine Wu', 'email': 'katherine.wu@mongodb.com', 'username': 'kaywux'}Message: (cherry picked from commit 365905c56bb39c82e729df1a4b77de797606ba5e) | |||||||||||||||||||||||||||
| Comment by Jeremy Mikola [ 15/Jun/21 ] | |||||||||||||||||||||||||||
|
katherine.wu: Ah, I didn't realize backports use their own tickets. Relying on that to track the downstream change for drivers works for me. Thanks! | |||||||||||||||||||||||||||
| Comment by Katherine Wu (Inactive) [ 15/Jun/21 ] | |||||||||||||||||||||||||||
|
jmikola this patch is in master (currently 5.1.0) and is not yet in any 5.0 release. I filed BACKPORT-9664 which tracks the work to backport it into a 5.0 preview release (specifically rc2 since that is targeted for the 16th). I was planning to use the "Downstream Team Attention" for drivers for that ticket only to avoid duplication, but can also mention that here. | |||||||||||||||||||||||||||
| Comment by Jeremy Mikola [ 14/Jun/21 ] | |||||||||||||||||||||||||||
|
katherine.wu: Should "Downstream Team Attention" at least impact drivers since we have spec tests depending on this fix? | |||||||||||||||||||||||||||
| Comment by Githook User [ 14/Jun/21 ] | |||||||||||||||||||||||||||
|
Author: {'name': 'Katherine Wu', 'email': 'katherine.wu@mongodb.com', 'username': 'kaywux'}Message: | |||||||||||||||||||||||||||
| Comment by Katherine Wu (Inactive) [ 08/Jun/21 ] | |||||||||||||||||||||||||||
|
Got it, thanks for the context! From the release dashboard it looks like 5.0.0-rc1 is targeted for tomorrow, and there is no rc2 planned so unfortunately this fix will not make it into a preview release. I'll start work on this soon, and once it's complete can see about the possibility of backporting it into rc1 so drivers can verify before the final release. | |||||||||||||||||||||||||||
| Comment by Jeremy Mikola [ 07/Jun/21 ] | |||||||||||||||||||||||||||
|
In my last comment, "5.0 final" was referring to the 5.0.0 stable release. A preview release would be anything before that (e.g. rc0, rc1, rc2). Ideally, a fix should be available in some release before the final so that we (drivers) can verify and test that it has been fixed. | |||||||||||||||||||||||||||
| Comment by Jeffrey Yemin [ 07/Jun/21 ] | |||||||||||||||||||||||||||
|
Here's another example, which charlie.swanson says has the same root cause. I can repro this on a standalone. This command:
fails with
| |||||||||||||||||||||||||||
| Comment by Githook User [ 07/Jun/21 ] | |||||||||||||||||||||||||||
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: | |||||||||||||||||||||||||||
| Comment by Jeremy Mikola [ 07/Jun/21 ] | |||||||||||||||||||||||||||
|
Note: this issue caused a failure in the spec tests for | |||||||||||||||||||||||||||
| Comment by Jeremy Mikola [ 04/Jun/21 ] | |||||||||||||||||||||||||||
|
Cross-referencing with |