[SERVER-57492] Side table writes insert more than just the keystring Created: 07/Jun/21 Updated: 29/Oct/23 Resolved: 17/Jun/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | 4.4.0, 5.0.0-rc0 |
| Fix Version/s: | 4.4.7, 5.0.0-rc4, 5.1.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Daniel Gottlieb (Inactive) | Assignee: | Louis Williams |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
|||||||||||||||||
| Backwards Compatibility: | Fully Compatible | |||||||||||||||||
| Operating System: | ALL | |||||||||||||||||
| Backport Requested: |
v5.0, v4.4
|
|||||||||||||||||
| Steps To Reproduce: |
|
|||||||||||||||||
| Sprint: | Execution Team 2021-06-28 | |||||||||||||||||
| Participants: | ||||||||||||||||||
| Description |
|
Writes to the side table re-use a BufBuilder to write keystrings to the hybrid index build side-table. It seems the BinData value in the side-write gets the a length derived from the capacity of the builders buffer instead of the length. This results in (at best) wasteful resource usage (for example writing out 512 bytes for 5 byte keystrings) and (at worst) a correctness problem due to undefined behavior. |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 29/Jun/21 ] |
|
Author: {'name': 'Louis Williams', 'email': 'louis.williams@mongodb.com', 'username': 'louiswilliams'}Message: This fixes a bug where extra data in the form of uninitialized memory was being This commit also renames BufBuilder::getSize() to capacity() to conform (cherry picked from commit ba81849df916f6c417585c6cd51e6508be5001fe) |
| Comment by Githook User [ 23/Jun/21 ] |
|
Author: {'name': 'Louis Williams', 'email': 'louis.williams@mongodb.com', 'username': 'louiswilliams'}Message: This fixes a bug where extra data in the form of uninitialized memory was being This commit also renames BufBuilder::getSize() to capacity() to conform (cherry picked from commit ba81849df916f6c417585c6cd51e6508be5001fe) |
| Comment by Githook User [ 17/Jun/21 ] |
|
Author: {'name': 'Louis Williams', 'email': 'louis.williams@mongodb.com', 'username': 'louiswilliams'}Message: This fixes a bug where extra data in the form of uninitialized memory was being This commit also renames BufBuilder::getSize() to capacity() to conform |