[SERVER-57507] Change maxTimeMS in collMod command in resharding_disallow_writes test Created: 07/Jun/21  Updated: 29/Oct/23  Resolved: 10/Jun/21

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 5.0.0-rc2, 5.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Luis Osta (Inactive) Assignee: Luis Osta (Inactive)
Resolution: Fixed Votes: 0
Labels: sharding-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Backport Requested:
v5.0
Sprint: Sharding 2021-06-14
Participants:
Linked BF Score: 47
Story Points: 1

 Description   

In the postCheckConsistencyFn passed down to 'withReshardingInBackground' in `reshardind_disallow_writes.js` test, the collMod command gets called with a maxTimeMS of 5000.

This is an issue in slower variants as some are configured with a low executor pool size. Hence there's no assurance that the command will be addressed in 5000 ms.

 

The simplest solution would either be to remove the maxTimeMS (which uses the default) or extend it to a larger number like 30,000 MS.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 10/Jun/21 ]

Author:

{'name': 'Luis Osta', 'email': 'luis.osta@mongodb.com', 'username': 'LuisOsta'}

Message: SERVER-57507 Change maxTimeMS in collMod command in resharding_disallow_writes test
Branch: v5.0
https://github.com/mongodb/mongo/commit/e2d9cf918e316e359b5cc03317c8e043771451c2

Comment by Githook User [ 10/Jun/21 ]

Author:

{'name': 'Luis Osta', 'email': 'luis.osta@mongodb.com', 'username': 'LuisOsta'}

Message: SERVER-57507 Change maxTimeMS in collMod command in resharding_disallow_writes test
Branch: master
https://github.com/mongodb/mongo/commit/ea0bb439813fe02f5f962a1438d78d263d07243d

Comment by Max Hirschhorn [ 07/Jun/21 ]

The simplest solution would either be to remove the maxTimeMS (which uses the default) or extend it to a larger number like 30,000 MS.

I think the maxTimeMS can be removed altogether from the test for the commands which are expected to fail with a ReshardCollectionInProgress error response. Omitting maxTimeMS from the command means the collMod command will be allowed to execute until it reaches the uassert() which throws ReshardCollectionInProgress.

Generated at Thu Feb 08 05:42:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.