[SERVER-57603] timeseries::MinMax::minUpdates/maxUpdates should consider calls to timeseries::MinMax::min/max when determining updates to include Created: 10/Jun/21 Updated: 29/Oct/23 Resolved: 21/Jun/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.4, 5.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Gregory Noma | Assignee: | Kris Satya (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | time-series | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Backport Requested: |
v5.0
|
||||||||||||
| Sprint: | Execution Team 2021-06-28 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
timeseries::MinMax::minUpdates/maxUpdates returns updates that have been made to the min/max since the last time the function was called. However, really it should really also consider any calls to timeseries::MinMax::min/max. The timeseries::MinMax usage pattern for time-series inserts is that timeseries::MinMax::min/max is called when a bucket is first created, and then subsequent inserts which update an existing bucket use timeseries::MinMax::minUpdates/maxUpdates. This means that, due to the behavior described above, the first call to timeseries::MinMax::minUpdates/maxUpdates for a given bucket includes updates for the entire min/max, as opposed to just the changes since the bucket was originally inserted. This is not a correctness issue, but does mean that applying the diff to the bucket may be doing extra unnecessary work in this case. |
| Comments |
| Comment by Githook User [ 14/Oct/21 ] |
|
Author: {'name': 'Kris Satya', 'email': 'kris.satya@mongodb.com', 'username': 'KoolCards'}Message: (cherry picked from commit af64b76d4c5a8f0c04eb703b40ce54ac61fd71ab) |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 21/Jun/21 ] |
|
Author: {'name': 'Kris Satya', 'email': 'kris.satya@mongodb.com', 'username': 'KoolCards'}Message: |