[SERVER-57633] Remove disable warnings as error for xcode 12.4 builder Created: 11/Jun/21  Updated: 29/Oct/23  Resolved: 19/Aug/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Daniel Moody Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: servicearch-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-55447 Stand up an Xcode 12 builder on the X... Closed
is related to SERVER-48076 implicit conversion from 'long long' ... Closed
is related to SERVER-48079 implicit conversion from 'long long' ... Closed
is related to SERVER-59098 implicit conversion from 'long long' ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2021-08-23
Participants:
Story Points: 2

 Description   

The latest xcode version raises new warning with our code. Fix the warnings and remove the flag from the builder.

 

Acceptance Criteria: Fix trivial warnings and file tickets for non-trivial warnings. 



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 19/Aug/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-57633 remove --disable-warnings-as-errors from xcode 12.4 builders
Branch: master
https://github.com/mongodb/mongo/commit/cb908c8437e2a8b189d37f44a48061364397829d

Comment by Githook User [ 19/Aug/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-57633 fix implicit long long to double conversion in unit tests
Branch: master
https://github.com/mongodb/mongo/commit/ebf3af24d79133eddc61309d85f4267b69795d79

Comment by Githook User [ 19/Aug/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-57633 SERVER-59098 fix implicit long long to double conversion in window_function_sum.cpp
Branch: master
https://github.com/mongodb/mongo/commit/cbb527e1b930a4d55deb499312dce917cf491558

Comment by Githook User [ 19/Aug/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-57633 SERVER-48079 fix implicit long long to double conversion in summation.cpp
Branch: master
https://github.com/mongodb/mongo/commit/11c215d484165aa465bd16fbf8e0379d5f30aec0

Comment by Githook User [ 18/Aug/21 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-57633 SERVER-48076 fix implicit long long to double conversion in BSONElement::tryCoerce()
Branch: master
https://github.com/mongodb/mongo/commit/ced65a176cab202d5abf57488f777189f27d7e41

Comment by Benety Goh [ 04/Aug/21 ]

SERVER-48076 SERVER-48079 SERVER-59098 point to tickets where application behavior may be affected.

Generated at Thu Feb 08 05:42:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.