[SERVER-57659] mongoldap should not log in color to non-tty by default Created: 11/Jun/21  Updated: 29/Oct/23  Resolved: 28/Jun/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Mark Benvenuto Assignee: Aldo Aguilar
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Security 2021-06-28
Participants:

 Description   

Mongoldap defaults to outputing in color. It should be changed to not log in color when outputing to a non-tty.

By default LDAPToolOptions.color defaults to true on Linux. The color set LDAPToolOptions.color to false if the user did not specify color on the command line.

See https://man7.org/linux/man-pages/man3/isatty.3.html for detecting if stdout is a tty.

 



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 25/Jun/21 ]

Author:

{'name': 'aldo-aguilar', 'email': 'aldo.aguilar@mongodb.com'}

Message: SERVER-57659 no longer logging color for non-tty by default, with windows support
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/b9c7d548b69f9ef9ad94df584c1a76e961254b43

Comment by Githook User [ 23/Jun/21 ]

Author:

{'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}

Message: Revert "SERVER-57659 no longer using color for non-tty file descriptors"

This reverts commit 8f7446d1eac1f8371bf5a9a464b84357cf1f0315.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/781154c4681917e9573f4cc480119fe5992c8c8c

Comment by Githook User [ 22/Jun/21 ]

Author:

{'name': 'aldo-aguilar', 'email': 'aldo.aguilar@mongodb.com'}

Message: SERVER-57659 no longer using color for non-tty file descriptors
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/8f7446d1eac1f8371bf5a9a464b84357cf1f0315

Comment by Githook User [ 22/Jun/21 ]

Author:

{'name': 'aldo-aguilar', 'email': 'aldo.aguilar@mongodb.com'}

Message: SERVER-57659 terminal will default to color and non-tty will default to no color. users can change this by setting the --color flag
Branch: SERVER-57681
https://github.com/10gen/mongo-enterprise-modules/commit/f3fe711786cea8b3edfcca8d9e9f3c7056af2650

Comment by Githook User [ 22/Jun/21 ]

Author:

{'name': 'aldo-aguilar', 'email': 'aldo.aguilar@mongodb.com'}

Message: SERVER-57659 no longer displaying color based on color flag
Branch: SERVER-57681
https://github.com/10gen/mongo-enterprise-modules/commit/a291fca558a0450feee43014e4efb69c9730e461

Comment by Githook User [ 22/Jun/21 ]

Author:

{'name': 'aldo-aguilar', 'email': 'aldo.aguilar@mongodb.com'}

Message: SERVER-57659 no longer using color for non-tty file descriptors
Branch: SERVER-57681
https://github.com/10gen/mongo-enterprise-modules/commit/f037d233ec3354bcc451eeefde7539b31af288f0

Generated at Thu Feb 08 05:42:27 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.