[SERVER-57723] Deduplicate last-continuous and last-lts multiversion tasks if the versions are identical Created: 15/Jun/21  Updated: 29/Oct/23  Resolved: 27/Oct/21

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 5.2.0

Type: Task Priority: Major - P3
Reporter: Robert Guo (Inactive) Assignee: Mikhail Shchatko
Resolution: Fixed Votes: 0
Labels: tig-multiversion
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-58834 Update FCV constants in server code b... Closed
Duplicate
is duplicated by SERVER-57012 Deduplicate last-continuous and last-... Closed
Related
Backwards Compatibility: Fully Compatible
Sprint: STM 2021-11-01
Participants:
Linked BF Score: 50
Story Points: 1

 Description   

Since 5.0 is both last-its and last-continuous, we should not need to run both by proactively checking that the versions are identical in multiversionconstants.py

Exclusions in backports_required_multiversion.yml only needed to be added to the last-lts section when it's equal to last-continuous. Since the next time last-continuous is updated, the last-continuous section should be cleared out.

For future lts releases, last-lts and last-continuous would be identical. We therefore only run multiversion tests once.

The last-lts and last-continuous check can be done by checking multiversionconstants.py



 Comments   
Comment by Githook User [ 27/Oct/21 ]

Author:

{'name': 'Mikhail Shchatko', 'email': 'mikhail.shchatko@mongodb.com', 'username': 'MikhailShchatko'}

Message: SERVER-57723 Deduplicate last-continuous and last-lts multiversion tasks if the versions are identical
Branch: master
https://github.com/mongodb/mongo/commit/b974dfd8389196bb7e744b7e19b7b48954c7dd40

Comment by Robert Guo (Inactive) [ 21/Oct/21 ]

mikhail.shchatko Misha I'm going to reassign this ticket to you. It should just be an if-condition above the version loop we discussed earlier, something like if multiversionconstants.LAST_LTS_FCV == multiversionconstants.LAST_CONTINUOUS_FCV: return ["last-lts"]. Let me know if it turns out to be more involved.

Comment by Githook User [ 20/Oct/21 ]

Author:

{'name': 'Robert Guo', 'email': 'robert.guo@mongodb.com'}

Message: SERVER-57723 remove task generation debug logs
Branch: master
https://github.com/mongodb/mongo/commit/dffc83bf53d4a80dd48393ea1a31e08aa6eb4d2a

Comment by Robert Guo (Inactive) [ 21/Sep/21 ]

xuerui.fa Yes, let me pull this forward. There're a couple of places that currently assume last-lts is identical to last-continuous, which will break after 5.1 branching.

Generated at Thu Feb 08 05:42:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.