[SERVER-57933] Don't override err exit in prelude_venv.sh Created: 22/Jun/21 Updated: 29/Oct/23 Resolved: 24/Jun/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.0-rc5, 5.1.0-rc0 |
| Type: | Bug | Priority: | Critical - P2 |
| Reporter: | Robert Guo (Inactive) | Assignee: | Richard Samuels (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Backport Requested: |
v5.0
|
||||
| Sprint: | STM 2021-06-28 | ||||
| Participants: | |||||
| Story Points: | 0 | ||||
| Description |
|
We currently use set +e at the end of the activate_venv, which can cause the shell script to never fail if the shell never sets its own errexit value afterwards. (Most functions don't) |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 25/Jun/21 ] |
|
Author: {'name': 'Richard Samuels', 'email': 'richard.l.samuels@gmail.com', 'username': 'richardsamuels'}Message: (cherry picked from commit 7d07ffc36c97d632e59c351d15610e0ff2ffab42) |
| Comment by Githook User [ 22/Jun/21 ] |
|
Author: {'name': 'Richard Samuels', 'email': 'richard.l.samuels@gmail.com', 'username': 'richardsamuels'}Message: |