[SERVER-58024] Audit NetworkInterfaceTL for calls to exception-throwing fns in getAsync continuations Created: 23/Jun/21  Updated: 29/Oct/23  Resolved: 28/Feb/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: George Wangensteen Assignee: Daniel Morilha (Inactive)
Resolution: Fixed Votes: 0
Labels: servicearch-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Service Arch 2022-1-24, Service Arch 2022-2-07, Service Arch 2022-2-21, Service Arch 2022-03-07
Participants:
Story Points: 4

 Description   

In SERVER-49435, we observed an instance of an exception-throwing function being called from a getAsync continuation. getAsync continuations are effectively noexcept (there is no "correct" context in which to handle an async-exception, so the process is terminated).

Because that ticket was causing a hot BF, we elected to simply fix the issue minimally by converting the relevant exception to a status within the function called in getAsync. But we already have found at least one other instance of this problem that has not yet been caught in tests: the call to continueExhaustRequest in a getAsync here may throw via its call to setTimer.

As much of the code in this class is run in getAsync continuations, and we have already encountered this twice, we should
1) Fix the issue described in the last paragraph
2) Audit all the getAsync continuations in this file to make sure they don't call into functions that may throw.



 Comments   
Comment by Githook User [ 25/Feb/22 ]

Author:

{'name': 'Daniel Morilha', 'email': 'daniel.morilha@mongodb.com', 'username': 'daniel-mdb'}

Message: SERVER-58024 Audit NetworkInterfaceTL for calls to exception-throwing fns in getAsync continuations
Branch: master
https://github.com/mongodb/mongo/commit/e83715d39cc173ddf5b981dfd73be549a9e3f81b

Comment by Daniel Morilha (Inactive) [ 20/Jan/22 ]

In review

Generated at Thu Feb 08 05:43:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.