[SERVER-58071] Audit uses of FeatureFlag::isEnabledAndIgnoreFCV()(QO) Created: 24/Jun/21 Updated: 13/Sep/21 Resolved: 10/Sep/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Hana Pearlman | Assignee: | Ted Tuckman |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | query-director-triage | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Operating System: | ALL | ||||||||
| Sprint: | QO 2021-09-20 | ||||||||
| Participants: | |||||||||
| Description |
|
According to documentation here and here, we should prefer to use FeatureFlag::isEnabled() over FeatureFlag::isEnabledAndIgnoreFCV() because it will prevent upgrade/downgrade issues. There are a couple of occurrences of FeatureFlag::isEnabledAndIgnoreFCV() in query code where we may not want to ignore FCV. This ticket is to audit our feature flag checks and make any changes to ensure we're following this guidance. |
| Comments |
| Comment by Sam Mercier [ 13/Sep/21 ] |
|
For $densify, it's also important to note that we have a separate FCV check from the isEnabledAndIgnoreFCV call. |
| Comment by Ethan Zhang (Inactive) [ 27/Aug/21 ] |
|
The QO ones are:
|