[SERVER-58072] Audit uses of FeatureFlag::isEnabledAndIgnoreFCV() (QE) Created: 24/Jun/21  Updated: 29/Oct/23  Resolved: 03/Sep/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Hana Pearlman Assignee: Jennifer Peshansky (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-58071 Audit uses of FeatureFlag::isEnabledA... Closed
Backwards Compatibility: Fully Compatible
Sprint: Query Execution 2021-07-12, Query Execution 2021-07-26, QE 2021-08-09, QE 2021-09-06, QE 2021-09-20
Participants:

 Description   

According to documentation here and here, we should prefer to use FeatureFlag::isEnabled() over FeatureFlag::isEnabledAndIgnoreFCV() because it will prevent upgrade/downgrade issues. There are a couple of occurrences of FeatureFlag::isEnabledAndIgnoreFCV() in query code where we may not want to ignore FCV. This ticket is to audit our feature flag checks and make any changes to ensure we're following this guidance.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 03/Sep/21 ]

Author:

{'name': 'Jennifer Peshansky', 'email': 'jennifer.peshansky@mongodb.com', 'username': 'jenniferpeshansky'}

Message: SERVER-58072 Changed unnecessary uses of isEnabledAndIgnoreFCV() to isEnabled(serverGlobalParams.featureCompatibility)
Branch: master
https://github.com/mongodb/mongo/commit/274ef1d81896afd0502632b62069da1c9f82f575

Comment by Kyle Suarez [ 06/Aug/21 ]

I haven't had time to investigate this – throwing this back into the triage queue for discussion.

Generated at Thu Feb 08 05:43:30 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.