[SERVER-58082] Fail resharding operation if allowMigrations has already been set to false Created: 24/Jun/21 Updated: 29/Oct/23 Resolved: 20/Aug/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.4, 5.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Max Hirschhorn | Assignee: | Randolph Tan |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Backport Requested: |
v5.0
|
||||||||||||
| Sprint: | Sharding 2021-07-12, Sharding 2021-07-26, Sharding 2021-08-09, Sharding 2021-08-23 | ||||||||||||
| Participants: | |||||||||||||
| Story Points: | 1 | ||||||||||||
| Description |
|
The allowMigrations field was initially added to the config.collections entry as part of
|
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 22/Sep/21 ] |
|
Author: {'name': 'Randolph Tan', 'email': 'randolph@10gen.com', 'username': 'renctan'}Message: (cherry picked from commit 1bf0b9e307160213b47a1b996ea2abb68be1169f) |
| Comment by Githook User [ 20/Aug/21 ] |
|
Author: {'name': 'Randolph Tan', 'email': 'randolph@10gen.com', 'username': 'renctan'}Message: |
| Comment by Max Hirschhorn [ 25/Jun/21 ] |
|
kaloian.manassiev, I don't believe this is a problem in the code today for exactly the reason you raised about the DDL coordinators. I filed this ticket to future-proof things. To me, setting allowMigrations to false should be a compare-and-swap kind of operation and resharding doesn't currently do the compare portion. |
| Comment by Kaloian Manassiev [ 25/Jun/21 ] |
|
Currently only DDL operations set the allowMigrations field. Since only one DDL can run per database currently, it shouldn't be possible that resharding finds it set (resharding has a fake DDL coordinator on the primary). Did you find this through a BF by any chance? |