[SERVER-58123] Avoid logging multiple times when restarting cancelled heartbeats Created: 28/Jun/21 Updated: 29/Oct/23 Resolved: 05/Sep/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.2.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Xuerui Fa | Assignee: | Evelyn Wu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Assigned Teams: |
Replication
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Sprint: | Repl 2023-09-04, Repl 2023-09-18 | ||||
| Participants: | |||||
| Linked BF Score: | 126 | ||||
| Description |
|
In _restartScheduledHeartbeats_inLock(), we will only restart heartbeats that have been scheduled, not sent. However, we do not check if those scheduled heartbeats have been cancelled or not, and we will immediately log that we are restarting heartbeats to that target. As a result, it is possible for us to log that we are restarting heartbeats multiple times to a single target, making the logs confusing and difficult to debug. We should move the logs to when we actually send a new heartbeat request to the target instead. This should only log once. |
| Comments |
| Comment by Githook User [ 05/Sep/23 ] |
|
Author: {'name': 'Evelyn Wu', 'email': 'evelyn.wu@mongodb.com', 'username': 'evelynwumongo'}Message: |