[SERVER-58140] Final sweep through the tests/product code to ensure no unintended legacy op code remains Created: 28/Jun/21 Updated: 29/Oct/23 Resolved: 10/Aug/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Irina Yatsenko (Inactive) | Assignee: | Yoon Soo Kim |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | QE 2021-08-09, QE 2021-08-23 |
| Participants: |
| Description |
|
We've split the removal of the legacy opcodes into logical tasks that can be handled in parallel by multiple people, however, that creates risk that due to inter-dependencies between the tasks we might miss some of the legacy ops handling code. This task should be last in the epic to confirm no loose ends remain. |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Yoon Soo Kim [ 09/Aug/21 ] |
|
Just found that UpdateOp|DeleteOp::parseLegacy can be removed since we do not support legacy writes any more. One caveat is that write_ops_parsers_test.cpp and protocol_fuzzer.cpp are using those methods. I think I can remove legacy update/delete tests too. And I think makeDeprecatedXXXMessage to op_legacy_integration_test.cpp since it’s the only remaining user of those functions after removing legacy update/delete test cases from write_ops_parsers_test.cpp. |
| Comment by Yoon Soo Kim [ 09/Aug/21 ] |
|
DBQueryInfo probably can be deleted since DBQuery class is defined in query.js. Update: It turned out that DBQueryInfo is used for array indexing for cursor. We can't remove it. |