[SERVER-58204] Instrumentation for socket lifecycle events Created: 01/Jul/21  Updated: 27/Oct/23  Resolved: 28/Oct/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0.7

Type: Bug Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Gone away Votes: 0
Labels: carry-over, servicearch-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
related to SERVER-58105 Improve exception handling in ASIOSes... Backlog
Operating System: ALL
Backport Requested:
v5.0
Sprint: Service Arch 2021-07-12, Service Arch 2021-08-09, Service Arch 2021-08-23
Participants:
Linked BF Score: 129
Story Points: 3

 Description   

Rare setsockopt failures of BF-21429 and related failures point to some kind of undiagnosed sync problem whereby a socket is perhaps closed or not yet opened and we are trying and failing to configure it.

It would be helpful to have a debug trace of a Socket or filedescriptor handle's history to diagnose failures like this. Currently these failures are somewhat stuck.



 Comments   
Comment by Githook User [ 17/Mar/22 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-58204 physical layout: session_asio.cpp and asio_utils.cpp

  • bring GenericSocket into ASIOSession class
  • refactor/minimize AsyncHandlerHelper traits
  • no logging in headers
  • fix sign extension bugs and conform to Winsock select requirements

(cherry picked from commit a57e4d409a81be929d4830199797c675322ae164)
Branch: LB
https://github.com/mongodb/mongo/commit/b1f50c767f9513db31d94b3d4d0b8c0cefd593a4

Comment by Githook User [ 07/Mar/22 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-58204 physical layout: session_asio.cpp and asio_utils.cpp

  • bring GenericSocket into ASIOSession class
  • refactor/minimize AsyncHandlerHelper traits
  • no logging in headers
  • fix sign extension bugs and conform to Winsock select requirements

(cherry picked from commit a57e4d409a81be929d4830199797c675322ae164)
Branch: v5.0
https://github.com/mongodb/mongo/commit/a13b1d56f04cc83374c3a29c668e7b421e5e32f6

Comment by Billy Donahue [ 28/Oct/21 ]

I think blake.oler's recent work superseded this ticket, really.

Comment by Lauren Lewis (Inactive) [ 28/Oct/21 ]

billy.donahue / blake.oler is this still work we need to do?

Comment by Githook User [ 06/Aug/21 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-58204 physical layout: session_asio.cpp and asio_utils.cpp

Comment by Billy Donahue [ 29/Jul/21 ]

Preliminary work.
Repairs some bugs in the session_asio etc and moves large functions into proper .cpp files.

https://mongodbcr.appspot.com/812730043/

Generated at Thu Feb 08 05:43:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.