[SERVER-58210] Clean up the code for rpc protocol negotiation of the shell (or not) Created: 01/Jul/21 Updated: 29/Oct/23 Resolved: 01/Oct/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Yoon Soo Kim | Assignee: | David Storch |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Minor Change | ||||||||||||||||
| Sprint: | QE 2021-08-23, QE 2021-09-06, QE 2021-09-20, QE 2021-10-04 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
We need to think about whether to remove rpc protocol negotiation code all together from the shell or not. Discussion on this: https://github.com/10gen/mongo/pull/23#pullrequestreview-697356322 Shell's get(set)ClientRPCProtocol/get(set)ServerRPCProtocol are also related. |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by David Storch [ 01/Oct/21 ] |
|
anna.henningsen, this patch removed getClientRPCProtocols() and setClientRPCProtocols() from the legacy shell. They are no longer needed because as of 5.1, neither the shell nor the server support any other RPC protocol other than OP_MSG. I'm pinging you just in case a similar situation applies to mongosh. |
| Comment by Githook User [ 01/Oct/21 ] |
|
Author: {'name': 'David Storch', 'email': 'david.storch@mongodb.com', 'username': 'dstorch'}Message: |