[SERVER-58301] Add more diagnostics to Watchdog tests Created: 06/Jul/21 Updated: 06/Dec/22 |
|
| Status: | Backlog |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Amirsaman Memaripour | Assignee: | Backlog - Service Architecture |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | sa-remove-fv-backlog-22, save-for-celina | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Assigned Teams: |
Service Arch
|
||||
| Participants: | |||||
| Linked BF Score: | 0 | ||||
| Description |
|
The unit-tests for the watchdog could benefit from more diagnostics, in particular, logging in checks ran by WatchdogCheckThread and the deathCallback invoked by WatchdogMonitorThread. At a minimum, these logs should report the system time when running each callback. For example, consider WatchdogMonitorTest::PauseAndResum, defined here. We can changeĀ deathCallback to capture a pointer to the monitorĀ and report the generation numbers for the check and monitor threads, as well as the system time. The same applies to TestCounterCheck::run. The additional diagnostics could help with debugging failures caused by the execution platform (e.g., bad OS scheduling). |