[SERVER-58338] Return an error if client attempts an OP_QUERY command other than isMaster/hello Created: 07/Jul/21  Updated: 29/Oct/23  Resolved: 02/Aug/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Task Priority: Major - P3
Reporter: David Storch Assignee: Yoon Soo Kim
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-58337 Log deprecation warning and bump serv... Closed
Documented
Problem/Incident
Related
related to SERVER-61030 Add authenticate command to allowlist... Closed
related to SERVER-66806 Add the "getnonce" command to the "al... Closed
related to SERVER-24426 Remove unnecessary command metadata u... Open
related to SERVER-58981 Investigate why saslStart/saslContinu... Closed
related to SERVER-59300 Change AsyncDBClient to use OP_MSG fo... Closed
Backwards Compatibility: Major Change
Sprint: Query Execution 2021-07-26, QE 2021-08-09
Participants:
Linked BF Score: 163

 Description   

This is follow-on work to SERVER-58337. The OP_QUERY RPC protocol is deprecated in 5.0, so we can remove support for it in 5.1. As in the other related deprecation and removals (OP_INSERT, OP_KILL_CURSORS, OP_GET_MORE, etc.) we should continue to log a warning and bump the appropriate serverStatus counter prior to returning an error. Also, the error should be user-friendly, meaning that it should indicate that OP_QUERY commands, other than hello and isMaster, are no longer supported, as opposed to being some indecipherable error produced during validation of the incoming network message (e.g. "unknown op code 2004", or something similar).



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Generated at Thu Feb 08 05:44:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.