[SERVER-58379] Use and extend REGISTER_ACCUMULATOR_WITH_MIN_VERSION macro once FCV constants are upgraded Created: 08/Jul/21 Updated: 29/Oct/23 Resolved: 15/Sep/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Mihai Andrei | Assignee: | Mihai Andrei |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Sprint: | QE 2021-09-20 | ||||
| Participants: | |||||
| Linked BF Score: | 35 | ||||
| Description |
|
From the design: We will add a ‘featureFlagTopNAccumulator’ feature flag as part of this project to ensure that the new accumulators and expressions don’t get used when the FCV is less than 5.1. This feature flag can then be used with the appropriate ‘register’ macros to ensure that the new accumulators, window functions, and expressions are FCV gated properly. Additionally, these new accumulators will not be part of the stable API initially, so we will need to extend the REGISTER_ACCUMULATOR_WITH_MIN_VERSION macro to perform an api version check, similar to the ones which exist for expressions and pipeline stages. |
| Comments |
| Comment by Vivian Ge (Inactive) [ 06/Oct/21 ] |
|
Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you! |
| Comment by Githook User [ 15/Sep/21 ] |
|
Author: {'name': 'Mihai Andrei', 'email': 'mihai.andrei@10gen.com', 'username': 'mtandrei'}Message: |
| Comment by Githook User [ 14/Sep/21 ] |
|
Author: {'name': 'Uladzimir Makouski', 'email': 'uladzimir.makouski@mongodb.com', 'username': 'umakouski'}Message: Revert " This reverts commit 15c51de0d4700d490c71ca70f961c3c44c1d4a1c. |
| Comment by Githook User [ 13/Sep/21 ] |
|
Author: {'name': 'Mihai Andrei', 'email': 'mihai.andrei@10gen.com', 'username': 'mtandrei'}Message: |
| Comment by Mihai Andrei [ 31/Aug/21 ] |
|
Note that this would be a good ticket to introduce macros which allow accumulators to be registered conditionally (for example, based on a feature flag check) |