[SERVER-58490] Simplify/remove OpRunner(s) hierarchy in service_entry_point_mongos.cpp Created: 13/Jul/21 Updated: 29/Oct/23 Resolved: 25/Jul/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Irina Yatsenko (Inactive) | Assignee: | Mariano Shaar |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | QE 2021-08-09 |
| Participants: |
| Description |
|
After deprecating legacy op codes, it doesn't make sense anymore to have HandleRequest::OpRunnerBase class so that CommandOpRunner (now the only class that derives from the OpRunnerBase) could override the run() method. With only opMsg supported now we don't need the runtime polymorphism here.
|
| Comments |
| Comment by Githook User [ 30/Jun/22 ] |
|
Author: {'name': 'Mariano Shaar', 'email': 'mariano.shaar@mongodb.com', 'username': 'shaargtz'}Message: |
| Comment by David Storch [ 09/Aug/21 ] |
|
I'm fine not doing this as part of the current op code removal project, but I think it's worth keeping around as a minor code improvement that a new hire or external contributor could work on. For this reason, I'm re-opening this ticket and putting it into the triage queue. |