[SERVER-58533] Log FCV at initialization and on log rotation Created: 14/Jul/21  Updated: 29/Oct/23  Resolved: 03/Dec/21

Status: Closed
Project: Core Server
Component/s: Diagnostics, Logging
Affects Version/s: 5.0.0
Fix Version/s: 5.2.0

Type: Improvement Priority: Major - P3
Reporter: Kevin Arhelger Assignee: Vishnu Kaushik
Resolution: Fixed Votes: 2
Labels: auto-reverted, former-quick-wins
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Duplicate
is duplicated by SERVER-36826 Report setting of FCV in logs and dia... Closed
Problem/Incident
Related
related to SERVER-67219 remove OpObserverImpl dependency from... Closed
is related to SERVER-58534 Collect FCV in FTDC Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v5.1, v5.0, v4.4
Sprint: Repl 2021-11-01, Replication 2021-11-15, Replication 2021-11-29, Replication 2021-12-13
Participants:
Case:
Linked BF Score: 162

 Description   

It's currently difficult to tell what Feature Compatibility Version a given binary is started with. Logging the version at startup and at log rotation time would help to diagnose these cases.



 Comments   
Comment by Spencer Brown [ 03/Dec/21 ]

Agreed. I’m a TSE and it’ll make some cases easier and quicker to handle,
but we can live without.

Comment by Judah Schvimer [ 03/Dec/21 ]

In that case I will reject the backports. Any watchers can please comment if they think this is worth the cost and risk.

Comment by Vishnu Kaushik [ 03/Dec/21 ]

judah.schvimer I think it should be low risk since we are only adding logging.

The backport to 5.1 should be very clean. Backporting to 5.0 and 4.4 would basically result in a re-implementation because the FCV constants locations have changed after the Minimize Per-release Code Changes project, so there's some risk involved there.

Comment by Judah Schvimer [ 03/Dec/21 ]

vishnu.kaushik, how risky would you consider this backport?

Comment by Vishnu Kaushik [ 03/Dec/21 ]

We probably want to log the FCV on the older versions as well.

Comment by Githook User [ 03/Dec/21 ]

Author:

{'name': 'Vishnu Kaushik', 'email': 'vishnu.kaushik@mongodb.com', 'username': 'kauboy26'}

Message: SERVER-58533 Log FCV at initialization and on log rotation
Branch: master
https://github.com/mongodb/mongo/commit/6ef5da0c8cdce8a4398ad00ede82ffa674f4e62c

Comment by xgen-buildbaron-user [ 01/Dec/21 ]

Ticket re-opened due to revert. compile_all began a consistent failure of compile_all

Comment by Githook User [ 01/Dec/21 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com'}

Message: Revert "SERVER-58533 Log FCV at initialization and on log rotation"

This reverts commit 190c45ddd442812ed5f384002ba1d1c7722f3963.
Branch: master
https://github.com/mongodb/mongo/commit/5712c40efd2c6908fb562d7e6b1007298047afb5

Comment by Githook User [ 30/Nov/21 ]

Author:

{'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}

Message: SERVER-58533 Log FCV at initialization and on log rotation
Branch: master
https://github.com/mongodb/mongo/commit/190c45ddd442812ed5f384002ba1d1c7722f3963

Comment by Githook User [ 23/Nov/21 ]

Author:

{'name': 'Uladzimir Makouski', 'email': 'uladzimir.makouski@mongodb.com', 'username': 'umakouski'}

Message: Revert "SERVER-58533 Log FCV at initialization and on log rotation"

This reverts commit 5b6df52bd38e223fb186c6ede035de92abbeb82b.
Branch: master
https://github.com/mongodb/mongo/commit/3f38219a5305f7efb0de2562a9aca4f157bb1916

Comment by Githook User [ 22/Nov/21 ]

Author:

{'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}

Message: SERVER-58533 Log FCV at initialization and on log rotation
Branch: master
https://github.com/mongodb/mongo/commit/5b6df52bd38e223fb186c6ede035de92abbeb82b

Comment by Githook User [ 18/Nov/21 ]

Author:

{'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}

Message: SERVER-58533 Log FCV at initialization and on log rotation
Branch: master
https://github.com/mongodb/mongo/commit/b1c3be9ee85cc69314aa9eb78c7183f871465bcf

Comment by Eric Milkie [ 15/Jul/21 ]

FCV isn't necessarily loaded at startup, but we can log something at the moment when it is first definitively known. For most cases, this will be "soon after startup", but could be "indefinitely long after startup" in certain edge cases.

Generated at Thu Feb 08 05:44:47 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.