[SERVER-5856] make query optimizer code not access data in constructor Created: 16/May/12  Updated: 11/Jul/16  Resolved: 27/May/12

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 2.1.2

Type: Bug Priority: Blocker - P1
Reporter: Eliot Horowitz (Inactive) Assignee: Aaron Staple
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Operating System: ALL
Participants:

 Description   

If you look in src/mongo/util/stack_introspect.cpp
you'll see this:

if ( method == "MultiPlanScanner" ||
method == "QueryPlan" ||
method == "QueryPlanSet" ||
method == "QueryOptimizerCursorImpl" ||
method == "QueryPlanGenerator" )
return false;

if you remove those lines, you'll get fasserts when running tests

to fix, we can't access data in constructors



 Comments   
Comment by auto [ 25/May/12 ]

Author:

{u'login': u'astaple', u'name': u'Aaron', u'email': u'aaron@10gen.com'}

Message: SERVER-5856 Remove query optimizer specific exceptions from stack checking code.
Branch: master
https://github.com/mongodb/mongo/commit/48b8dc97c4c1e15746a077f64a63a0346e5db980

Comment by auto [ 25/May/12 ]

Author:

{u'login': u'astaple', u'name': u'Aaron', u'email': u'aaron@10gen.com'}

Message: SERVER-5856 Extract QueryOptimizerCursorImpl::init() and use for initialization, wrapped by QueryOptimizerCursorImpl::make().
Branch: master
https://github.com/mongodb/mongo/commit/b45a090c0f4f6c313c1ef2c9ed7029da0a41f047

Comment by auto [ 25/May/12 ]

Author:

{u'login': u'astaple', u'name': u'Aaron', u'email': u'aaron@10gen.com'}

Message: SERVER-5856 Extract QueryResponseBuilder::init() and use for initialization, wrapped by QueryResponseBuilder::make().
Branch: master
https://github.com/mongodb/mongo/commit/9064017c02475db4c3bcba842bca1c3991581a4a

Comment by auto [ 25/May/12 ]

Author:

{u'login': u'astaple', u'name': u'Aaron', u'email': u'aaron@10gen.com'}

Message: SERVER-5856 Pull FindingStartCursor::init() out of constructor and wrap initialization within FindingStartCursor::make().
Branch: master
https://github.com/mongodb/mongo/commit/7e20afe8f43b689f7e1364ae7636af05557f923c

Comment by auto [ 25/May/12 ]

Author:

{u'login': u'astaple', u'name': u'Aaron', u'email': u'aaron@10gen.com'}

Message: SERVER-5856 Extract MultiPlanScanner::init() and use for initialization, wrapped by MultiPlanScanner::make().
Branch: master
https://github.com/mongodb/mongo/commit/d7dad49026bf566904a38b750221c15b77efc1ea

Comment by auto [ 25/May/12 ]

Author:

{u'login': u'astaple', u'name': u'Aaron', u'email': u'aaron@10gen.com'}

Message: SERVER-5856 Pull QueryPlanSet::init() out of constructor and wrap initialization within QueryPlanSet::make().
Branch: master
https://github.com/mongodb/mongo/commit/41e1c9c10baf1d64397030c7d9466722da05fbaf

Comment by auto [ 25/May/12 ]

Author:

{u'login': u'astaple', u'name': u'Aaron', u'email': u'aaron@10gen.com'}

Message: SERVER-5856 Extract QueryPlan::init() and use for initialization, wrapped by QueryPlan::make().
Branch: master
https://github.com/mongodb/mongo/commit/073f9ec84eb5e198e95ab19bdde3f04761c14234

Generated at Thu Feb 08 03:10:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.