[SERVER-58564] Add missing bitcastTo()'s in SBE HashAgg/HashJoin unittests Created: 14/Jul/21  Updated: 29/Oct/23  Resolved: 15/Jul/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Eric Cox (Inactive) Assignee: Drew Paroski
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

There are some places in "sbe_hash_agg_test.cpp" and "sbe_hash_join_test.cpp" where sbe::Values are compared directly with native integer types, which is wrong.

Each place should be fixed to use bitcastTo() to convert the sbe::Value to the appropriate integer type first before performing the comparison.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 15/Jul/21 ]

Author:

{'name': 'Drew Paroski', 'email': 'drew.paroski@mongodb.com', 'username': 'paroski'}

Message: SERVER-58564 Add missing bitcastTo()'s in SBE HashAgg/HashJoin unittests
Branch: master
https://github.com/mongodb/mongo/commit/12c7f0f5198a03815ad152fd2f693eb08515cb2b

Generated at Thu Feb 08 05:44:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.