[SERVER-58622] DDL coordinator handle write concern error incorrectly when removing coordinator document Created: 16/Jul/21 Updated: 29/Oct/23 Resolved: 13/Jan/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 5.3.0, 5.0.6, 5.2.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Marcos José Grillo Ramirez | Assignee: | Marcos José Grillo Ramirez |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v5.2, v5.0
|
||||||||
| Sprint: | Sharding EMEA 2021-11-01, Sharding EMEA 2021-11-15, Sharding EMEA 2021-11-29, Sharding EMEA 2021-12-13, Sharding EMEA 2021-12-27, Sharding EMEA 2022-01-10, Sharding EMEA 2022-01-24 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 17 | ||||||||
| Description |
|
If a write concern error occurs when trying to remove the coordinator document the primary only service cleanup is not being executed, leaving the shard with a DDL coordinator service that will always return an error, even if the operation could be retried and the document could be removed successfully later on, this might be happening because it is not being considered that the _removeDocument function might throw. You can find a reproducible attached. |
| Comments |
| Comment by Githook User [ 20/Jan/22 ] |
|
Author: {'name': 'Marcos José Grillo Ramirez', 'email': 'marcos.grillo@mongodb.com', 'username': 'm4nti5'}Message: (cherry picked from commit 5fa70b4e4d6b4252fd505ab12cea771b197d2cf0) |
| Comment by Githook User [ 17/Jan/22 ] |
|
Author: {'name': 'Marcos José Grillo Ramirez', 'email': 'marcos.grillo@mongodb.com', 'username': 'm4nti5'}Message: (cherry picked from commit 5fa70b4e4d6b4252fd505ab12cea771b197d2cf0) |
| Comment by Githook User [ 13/Jan/22 ] |
|
Author: {'name': 'Marcos José Grillo Ramirez', 'email': 'marcos.grillo@mongodb.com', 'username': 'm4nti5'}Message: |
| Comment by Marcos José Grillo Ramirez [ 08/Nov/21 ] |
|
After talking with tommaso.tocci, we could either retry indefinitely the remove, or, find a way to retry the remove part. This should only happen if there are no step-downs. |