[SERVER-58635] Remove BufBuilder from Simple8b builder Created: 16/Jul/21  Updated: 29/Oct/23  Resolved: 03/Aug/21

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Henrik Edin Assignee: Henrik Edin
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-58681 Split up Simple8b in separate classes... Closed
is depended on by SERVER-58560 Implement algorithm to determine scal... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2021-08-09
Participants:

 Description   

BSONColumnBuilder will store Simple8b blocks in a higher level binary stream. This stream we will keep track of how many consecutive Simple8b blocks we have with a 4 bit count, meaning there can be a maximum of 16 consecutive blocks.

To avoid using too many temporary buffers where we need to copy the data we should change the Simple8b builder interface to return final Simple8b blocks via a callback. When calling Simple8b::append 0, 1, 2 or more Simple8b blocks may be finalized. A callback interface also provides a generic way to test which scale factor compresses best.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Githook User [ 03/Aug/21 ]

Author:

{'name': 'Henrik Edin', 'email': 'henrik.edin@mongodb.com', 'username': 'henrikedin'}

Message: SERVER-58635 Removed BufBuilder from Simple8b builder.

The class now writes finalized Simple-8b blocks using a callback.
Branch: master
https://github.com/mongodb/mongo/commit/87d85628153329eed1ba2ccdaad97289a74c2b4e

Generated at Thu Feb 08 05:45:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.